Trading made REALLY Simple

[gg53]

simplex wrote:

Ok:

gg53 wrote:

Functionality. We want to call that function (?) with user params like BeforeTrade/AfterTrade (minutes), Medium/High impact, Currency pair relevance.

BeforeTrade/AfterTrade (minutes) means number of minutes to next event and number of minutes after previous event? A Function? Would be nice. The indicator has got some nice features, but the overall architecture appears to be more or less monolithic. Will take a while to convert this into a set of functions that make sense. s.

That’s why I said Function (?)….

It can also be an external call.

…”BeforeTrade/AfterTrade (minutes) means number of minutes to next event and number of minutes after previous event? “…  –> Yes.

 

G.

[simplex]

Interesting:

Emonts wrote:

Today I gave VlanFx an update of the check news procedure/routine.

Looking forward to test it. Has it been posted somewhere before?

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[VlanFx]

@Emonts, I think you can post it here. More people have more time to test it. When they ‘OK’ it, I will add it.

 

[Emonts]

See attachment.

Simple indicator to show how to use is added.

This indicator only draws a rectangle with the colors, green, red, orange or yellow.

BR

 

Attachments:

You must be logged in to view attached files.

[simplex]

Thanks for contributing this:

Emonts wrote:

This indicator only draws a rectangle with the colors, green, red, orange or yellow.

Very simple output, but the code appears to be simply the best structured calendar lib so far – I like this!

Now I think this will be my last post here for 2015. Best wishes to all members and contributors – may 2016 be a great year for all of you!

simplex

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[simplex]

@Emonts:

Emonts wrote:

Simple indicator to show how to use is added.

I’ve done a quick and dirty code review now and like to post some remarks for discussion:

• EventKillTimer() missing
• symbol prefix / suffix is checked inside function getNewsInfoPair(). Better remove this for Penguin EA use (redundant logic!)
• panel object is not being deleted while deinitialization
• custom enumeration for numeric impact values would make sense
• purpose of variable afxBroker ?
• variable strippedPair never used after initialization
• filters skip = true in func getNewsInfoPair should be checked
• heavy use of global variables should be checked (e.g. boolean skip) and reduced
• several compiler warnings to care for
• ‘if’ logic in event handler OnTimer() can be simplified
• several variables are never used and can be removed, e.g. Show_CNY_News
• news events are checked in OnTimer() event handler. This is ok, but it should be ensured in the EA that no different timer intervals are required.
• if a more flexible use of news events is required, declaration of a compound data type for news would make sense (keyword struct)

This might look like a long list if issues to care for, and possibly it’s not yet complete, but I still think that Emonts’ code is the best to start with. Such simple issues in a well-structured program are much easier to fix than rebuilding a poorly structured one.

Maybe we should move further discussion of details to the Coders’ Chat Thread. So this main thread can stay clean.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[Emonts]

Hi,

 

I gonna do some cleaning in the NewsInc_V2.0.mqh.

The other indi was just a quick and dirty  to show how to use the NewsInc_V2.0.mqh.

I had not the intention to use it at all.

But if wished  I can clean it up to and adapt the code according remarks.

 

BR

[simplex]

That’s great, @Emonts:

Emonts wrote:

I gonna do some cleaning in the NewsInc_V2.0.mqh.

Please note that not all of my above remarks are necessarily relevant for our EA.

Re. my remark about symbol prefix / suffix, @VlanFx would better decide what to do before you put together some sort of ‘final version’ for the EA. I just wanted to denote that there’s some redundant logic in your function code and the current EA code.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[simplex]

My version 1.0 of Volume Zone Oscillator. It consists of a simple indicator file, and an mqh-library which should be placed in the include folder.

In final and practical EA use, there will only be one line of code required:

varName = iiVZO(symb, tf, vzoPeriod, shift);

For debugging and optimizing the EA, a simple iCustom() call of the indicator can be coded (only buffer index 0 is active).

A more experimental version of the indicator to check out the second implementation  varName = iVZO(symb, tf, vzoPeriod, shift); is posted over here.

Note: the second ‘i’ in iiVZO stands for ‘instant’ VZO.

s.

Attachments:

You must be logged in to view attached files.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[simplex]

Hi @VlanFx:

I’m currently reviewing version 1.3 of the EA. In function CalcLot() you have the following line of code:

actualRisk = (100 * minLot * StopLoss * pipValue) / AccountBalance();

That variable actualRisk is never used thereafter. Is it reserved for some future use?

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[gg53]

simplex wrote:

Hi @VlanFx: I’m currently reviewing version 1.3 of the EA. In function CalcLot() you have the following line of code: actualRisk = (100 * minLot * StopLoss * pipValue) / AccountBalance(); That variable actualRisk is never used thereafter. Is it reserved for some future use? s.

actualRisk will later be used mainly for user display purposes.

 

G.

 

[gg53]

On TakeProfit:

While we wait for the skeleton of our EA to be finished (pre-conditions + Logic), lets discuss a much neglected topic of TakeProfit.

Besides the TrailingStop, once a trade is entered, most EA’s are basically remains static with their SL & TP. BUT the market keeps changing.

Here comes the concept of Dynamic/Adaptive TakeProfit target.

Our initial TakeProfit is based on ATR, which is good measure of Volatility, but it lacks the DIRECTION and TRENDINESS, which might change during the trade.

Here comes another indicator, the ADX, which tells us the underlying strength of the TREND.

If we combine the two, the ATR & ADX, we can move our TakeProfit target dynamically and adapt to changing market conditions.

 

Example: if we start with TakeProfit target as 1.5*ATR and the ADX is moving up, we can increase that target to 2*ATR, and reduce it to 1*ATR, or lower,  if it’s declining.

 

Initial suggestion to start “playing” with the “Adaptive TakeProfit” concept, are 20 day ATR (~120 on H4) and 18 day ADX (~108 on H4).

Play with this concept and see dramatic effects on the outcome profits.

 

Looking forward to see a FUNCTION that adds this feature to our skeleton EA.

 

G.

 

 

[simplex]

G:

gg53 wrote:

Looking forward to see a FUNCTION that adds this feature to our skeleton EA.

Do you mean a function that just displays the adaptive TP relative to the current bar, or a function setting an adaptive TP in relation to a given entry price, thus monitoring a certain trade?

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[gg53]

simplex wrote:

G:

gg53 wrote:

Looking forward to see a FUNCTION that adds this feature to our skeleton EA.

Do you mean a function that just displays the adaptive TP relative to the current bar, or a function setting an adaptive TP in relation to a given entry price, thus monitoring a certain trade? s.

A function setting an adaptive TP in relation to a given entry price, thus monitoring a certain trade. It’s an EA – what’s the point in something else?

 

G.

[IenDzi]

Does dynamic Take profit function is something like that?

• This reply was modified 10 years, 5 months ago by IenDzi.
• This reply was modified 10 years, 5 months ago by IenDzi.
• This reply was modified 10 years, 5 months ago by IenDzi.
• This reply was modified 10 years, 5 months ago by IenDzi.

Attachments:

You must be logged in to view attached files.

[simplex]

Thanks for clarifying:

gg53 wrote:

It’s an EA – what’s the point in something else?

Depends on the logic. Just wanted to be sure. From decades of IT development, I have some experience with incomplete or ambiguous requirements specifications. IMO, it makes sense to ask if you’re not sure what your communication partner intended.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[gg53]

Most EA’s are heavilly investing in BreakEven, StopLoss trailing, TrailingStops, etc.

The issue of TakeProfit remains static in most of them, so why not invest in Dynamic TakeProfit according to changing market?

 

G.

[simplex]

I absolutely support the idea:

gg53 wrote:

why not invest in Dynamic TakeProfit according to changing market?

My conceptual thoughts coded as an experimental indicator are posted over here.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[simplex]

@IenDzi:

IenDzi wrote:

Does dynamic Take profit function is something like that?

G. wrote:

… ADX is moving up …

He is referring to the ADX main line (MODE_MAIN). Your function uses +DI and -DI. It could possibly make sense to use +DI and -DI to indicate the end of a swing, but you will also require ADX Main to code G’s approach.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[mast83]

gg53 wrote:

Attached…   G. ATTACHMENTS: ClearMethod_01.mq4 ClearMethodSignals_01.mq4

 

Hi, do you have a version which has an option to change Time-Settings?

BR Marc

• This reply was modified 10 years, 5 months ago by mast83.

[simplex]

@mast83:

mast83 wrote:

do you have a version which has an option to change Time-Settings?

A HTF (high timeframe) version of my Clear Method Band is posted over here.

s.

A good trader is a realist who wants to grab a chunk from the body of a trend, leaving top- and bottom-fishing to people on an ego trip. (Dr. Alexander Elder)

[mast83]

Hi together,

I hope you’re all doing well and had a good start into 2016. Since one week I’m registered here at ‘pinguintraders’ and searched for several information, ideas and other stuff related to trading. I asked simplex if you can use my help for backtesting purposes or find other helpful stuff for your community ea.

From time to time I will send you information or add-ons for that ea. Nevertheless I’d like to congratulate you all for the effort in creating such an ea. I also made some backtest which were not so bad, but can be improved.

I will respond asap

 

BR Marc

[gg53]

mast83 wrote:

Hi together, I hope you’re all doing well and had a good start into 2016. Since one week I’m registered here at ‘pinguintraders’ and searched for several information, ideas and other stuff related to trading. I asked simplex if you can use my help for backtesting purposes or find other helpful stuff for your community ea. From time to time I will send you information or add-ons for that ea. Nevertheless I’d like to congratulate you all for the effort in creating such an ea. I also made some backtest which were not so bad, but can be improved. I will respond asap BR Marc

No point in testing the EA for profitability, major things are still missing from the Logic part, and some minor things are still missing from the pre-trade conditions.

Major issues on the Logic Entry/Exit part will be added AFTER the trade pre-conditions part of that EA is fully implemented.

 

G.

[mast83]

Hi together,

I searched for more information from chart and ClearMethod-Indicator. I implemented a filter which should help to find better entries and exits. For entrys I only use ClearMethod…
Please find two screenshots one without filter and antoher one incl. a special MA.

This is only an example…
In screenshot no 1 you can see all entries and exits made in Daily EURUSD from may till november 2015 (without filter).
1. Entry Short is a loss. 2. Entry Long is a loss. 3. Entry Short is a loss. 4. Entry Long is a loss.

In screenshot no 2 you can see all entries and exits made in Daily EURUSD from may till november 2015 (with filter).
1. line…no entry…MA and CM are not in line. 2. line entry and exit when MA turns red (exit is much earlier and limits losses). 4. line Entry Short with smaller loss when MA turns green (keep in mind that entry happens on a sunday candle..check your broker…) 6. line entry long (sunday Candle) and exit with 15 pips win when MA turns red. Line 8 entry in direction of CM and exit in line 9 with loss… 

I know that this test is very bad, but I searched for an extreme condition and found out that this MA is a good filter…it’s called ‘NonLag ma nrp & mtf + alerts 2.01’. Please do not pay attention on these small arrows…this is another indie which i check…

 

BR Marc

 

Attachments:

You must be logged in to view attached files.

[mast83]

Is there any documentation (outside the forum) like a pdf or better word document with release numbers? this could help to add changes / innovations / current status…logc parts (entres 7 exits) etc?

[Author]

Posts